-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PMREM banding on Pixel #18326
Fix PMREM banding on Pixel #18326
Conversation
The other option would be to change this line https://github.com/mrdoob/three.js/blob/dev/src/renderers/WebGLRenderer.js#L467 from |
Confirmed solved on my end. Thank you. Dev Example |
@sciecode I'm afraid the live link does not make sense since the build files are not updated yet. |
Forgot Edit: done. |
#16821 explains the change. I do not recall if I considered |
Yes, the banding is now gone on my Pixel 1 👍 |
Merging this and updating |
Thanks! |
Fixes #18265
The issue is that floor( x / pixelRatio * pixelRatio ) != x when pixelRatio is non-integer, due to floating point error. By adding half a pixel, we ensure floor always goes the right way.